Refactor AudioTrackDialog for improved localization and user experience #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amitojsingh
commented
Nov 7, 2025
amitojsingh
commented
- Updated text in AudioTrackDialog to utilize localized strings for better internationalization support.
- Enhanced user feedback by replacing hardcoded messages with dynamic string references for audio availability and request prompts.
- Added new localization strings for consistent messaging across multiple languages.
- Updated text in AudioTrackDialog to utilize localized strings for better internationalization support. - Enhanced user feedback by replacing hardcoded messages with dynamic string references for audio availability and request prompts. - Added new localization strings for consistent messaging across multiple languages.
Gauravjeetsingh
approved these changes
Nov 8, 2025
Gauravjeetsingh
left a comment
Gauravjeetsingh
left a comment
There was a problem hiding this comment.
Minor fix, you can merge after that.
| MAAFI_JI: "ਮਾਫ਼ ਕਰਨਾ ਜੀ 🙏🏽", | ||
| WE_DO_NOT_HAVE_AUDIOS_FOR: "ਸਾਡੇ ਕੋਲ ਇਹਨਾਂ ਲਈ ਆਡੀਓ ਨਹੀਂ ਹਨ", | ||
| REQUEST_AUDIO_FOR_THIS_PAATH: "ਇਸ ਪਾਠ ਲਈ ਆਡੀਓ ਦੀ ਬੇਨਤੀ ਕਰੋ।", | ||
| YET: "", |
There was a problem hiding this comment.
Missing the translation for YET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.